Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

petstore 1.0.18 has wrong scheme! #125

Closed
lvsecoto opened this issue Mar 11, 2024 · 5 comments
Closed

petstore 1.0.18 has wrong scheme! #125

lvsecoto opened this issue Mar 11, 2024 · 5 comments
Assignees
@frantuma

Comments

@lvsecoto
Copy link

pet.id.type should be integer

"Pet": {
                "required": [
                    "name",
                    "photoUrls"
                ],
                "type": "object",
                "properties": {
                    "id": {
                        "required": [
                            "name",
                            "photoUrls"
                        ],
                        "type": "object",
                        "properties": {
                            "id": {
                                "type": "integer",
                                "format": "int64",
                                "example": 10
                            },
                            "name": {
                                "type": "string",
                                "example": "doggie"
                            },
                            "category": {
                                "$ref": "#/components/schemas/Category"
                            },
                            "photoUrls": {
                                "type": "array",
                                "xml": {
                                    "wrapped": true
                                },
                                "items": {
                                    "type": "string",
                                    "xml": {
                                        "name": "photoUrl"
                                    }
                                }
                            },
                            "tags": {
                                "type": "array",
                                "xml": {
                                    "wrapped": true
                                },
                                "items": {
                                    "$ref": "#/components/schemas/Tag"
                                }
                            },
                            "status": {
                                "type": "string",
                                "description": "pet status in the store",
                                "enum": [
                                    "available",
                                    "pending",
                                    "sold"
                                ]
                            }
                        },
                        "xml": {
                            "name": "pet"
                        }
                    },
                    "name": {
                        "required": [
                            "name",
                            "photoUrls"
                        ],
                        "type": "object",
                        "properties": {
                            "id": {
                                "type": "integer",
                                "format": "int64",
                                "example": 10
                            },
                            "name": {
                                "type": "string",
                                "example": "doggie"
                            },
                            "category": {
                                "$ref": "#/components/schemas/Category"
                            },
                            "photoUrls": {
                                "type": "array",
                                "xml": {
                                    "wrapped": true
                                },
                                "items": {
                                    "type": "string",
                                    "xml": {
                                        "name": "photoUrl"
                                    }
                                }
                            },
                            "tags": {
                                "type": "array",
                                "xml": {
                                    "wrapped": true
                                },
                                "items": {
                                    "$ref": "#/components/schemas/Tag"
                                }
                            },
                            "status": {
                                "type": "string",
                                "description": "pet status in the store",
                                "enum": [
                                    "available",
                                    "pending",
                                    "sold"
                                ]
                            }
                        },
                        "xml": {
                            "name": "pet"
                        }
                    },
                    "category": {
                        "required": [
                            "name",
                            "photoUrls"
                        ],
                        "type": "object",
                        "properties": {
                            "id": {
                                "type": "integer",
                                "format": "int64",
                                "example": 10
                            },
                            "name": {
                                "type": "string",
                                "example": "doggie"
                            },
                            "category": {
                                "$ref": "#/components/schemas/Category"
                            },
                            "photoUrls": {
                                "type": "array",
                                "xml": {
                                    "wrapped": true
                                },
                                "items": {
                                    "type": "string",
                                    "xml": {
                                        "name": "photoUrl"
                                    }
                                }
                            },
                            "tags": {
                                "type": "array",
                                "xml": {
                                    "wrapped": true
                                },
                                "items": {
                                    "$ref": "#/components/schemas/Tag"
                                }
                            },
                            "status": {
                                "type": "string",
                                "description": "pet status in the store",
                                "enum": [
                                    "available",
                                    "pending",
                                    "sold"
                                ]
                            }
                        },
                        "xml": {
                            "name": "pet"
                        }
                    },
                    "photoUrls": {
                        "required": [
                            "name",
                            "photoUrls"
                        ],
                        "type": "object",
                        "properties": {
                            "id": {
                                "type": "integer",
                                "format": "int64",
                                "example": 10
                            },
                            "name": {
                                "type": "string",
                                "example": "doggie"
                            },
                            "category": {
                                "$ref": "#/components/schemas/Category"
                            },
                            "photoUrls": {
                                "type": "array",
                                "xml": {
                                    "wrapped": true
                                },
                                "items": {
                                    "type": "string",
                                    "xml": {
                                        "name": "photoUrl"
                                    }
                                }
                            },
                            "tags": {
                                "type": "array",
                                "xml": {
                                    "wrapped": true
                                },
                                "items": {
                                    "$ref": "#/components/schemas/Tag"
                                }
                            },
                            "status": {
                                "type": "string",
                                "description": "pet status in the store",
                                "enum": [
                                    "available",
                                    "pending",
                                    "sold"
                                ]
                            }
                        },
                        "xml": {
                            "name": "pet"
                        }
                    },
                    "tags": {
                        "required": [
                            "name",
                            "photoUrls"
                        ],
                        "type": "object",
                        "properties": {
                            "id": {
                                "type": "integer",
                                "format": "int64",
                                "example": 10
                            },
                            "name": {
                                "type": "string",
                                "example": "doggie"
                            },
                            "category": {
                                "$ref": "#/components/schemas/Category"
                            },
                            "photoUrls": {
                                "type": "array",
                                "xml": {
                                    "wrapped": true
                                },
                                "items": {
                                    "type": "string",
                                    "xml": {
                                        "name": "photoUrl"
                                    }
                                }
                            },
                            "tags": {
                                "type": "array",
                                "xml": {
                                    "wrapped": true
                                },
                                "items": {
                                    "$ref": "#/components/schemas/Tag"
                                }
                            },
                            "status": {
                                "type": "string",
                                "description": "pet status in the store",
                                "enum": [
                                    "available",
                                    "pending",
                                    "sold"
                                ]
                            }
                        },
                        "xml": {
                            "name": "pet"
                        }
                    },
                    "status": {
                        "required": [
                            "name",
                            "photoUrls"
                        ],
                        "type": "object",
                        "properties": {
                            "id": {
                                "type": "integer",
                                "format": "int64",
                                "example": 10
                            },
                            "name": {
                                "type": "string",
                                "example": "doggie"
                            },
                            "category": {
                                "$ref": "#/components/schemas/Category"
                            },
                            "photoUrls": {
                                "type": "array",
                                "xml": {
                                    "wrapped": true
                                },
                                "items": {
                                    "type": "string",
                                    "xml": {
                                        "name": "photoUrl"
                                    }
                                }
                            },
                            "tags": {
                                "type": "array",
                                "xml": {
                                    "wrapped": true
                                },
                                "items": {
                                    "$ref": "#/components/schemas/Tag"
                                }
                            },
                            "status": {
                                "type": "string",
                                "description": "pet status in the store",
                                "enum": [
                                    "available",
                                    "pending",
                                    "sold"
                                ]
                            }
                        },
                        "xml": {
                            "name": "pet"
                        }
                    }
                },
                "xml": {
                    "name": "pet"
                }
            },
@geoffw
Copy link

geoffw commented Mar 13, 2024

The yaml is correct but something from Commits on Mar 8, 2024 has broken the conversion to json and you can see this on the site https://petstore3.swagger.io/#/pet/findPetsByTags if you expand the response schema the datatypes are all wrong.

@lvsecoto
Copy link
Author

The yaml is correct but something from Commits on Mar 8, 2024 has broken the conversion to json and you can see this on the site https://petstore3.swagger.io/#/pet/findPetsByTags if you expand the response schema the datatypes are all wrong.

Yes! I also found this problem. Did the Open API json scheme changed?

@jasonHzq
Copy link

Any progress on this?

@char0n
Copy link
Member

char0n commented Mar 15, 2024

Yes, we're already looking into this

@austinvalle austinvalle mentioned this issue Mar 15, 2024
Closed
1 task
@frantuma frantuma self-assigned this Mar 18, 2024
frantuma added a commit to swagger-api/swagger-inflector that referenced this issue Mar 18, 2024
@frantuma
refs swagger-api/swagger-petstore#125 - fix default filter
7d65209
@frantuma frantuma mentioned this issue Mar 18, 2024
Merged
frantuma added a commit to swagger-api/swagger-inflector that referenced this issue Mar 18, 2024
@frantuma
refs swagger-api/swagger-petstore#125 - fix default filter
b52a6d0
@micryc micryc mentioned this issue Mar 19, 2024
Merged
@micryc
Copy link
Contributor

micryc commented Mar 19, 2024

Fixed by #129

@micryc micryc closed this as completed Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frantuma frantuma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@char0n @geoffw @jasonHzq @lvsecoto @frantuma @micryc