Dollar sign not works on copy / paste of curl command line

[jbarotin]

Content & configuration

I'm using swagger-ui to document an odata api

The curl command generated looks like this one :

curl -X GET "https://myservice.net/odata/v4/Items?$top=3" -H  "accept: application/json"

Is your feature request related to a problem?

A copy / copy and paste of the following command line (on Unix based OS), the url will be interpreted as https://myservice.net/odata/v4/Items?=3

Describe the solution you'd like

In order to make sure the dollar is not interpreted, it would be nice to have this kind of command line with parameter using single quote.

curl -X GET 'https://myservice.net/odata/v4/Items?$top=3' -H  'accept: application/json'

Describe alternatives you've considered

Otherwise dollar could be escaped, but I'm not sure it works under Windows :

curl -X GET "https://myservice.net/odata/v4/Items?\$top=3" -H  "accept: application/json"

Maybee using the url encoding code :

curl -X GET "https://myservice.net/odata/v4/Items?%24top=3" -H  "accept: application/json" 

[shockey]

Depending on the tradeoffs, it might be better to just always use singlequotes.

[shockey]

per @hkosova:

single quotes are for Bash and won't work in Windows cmd

[jbarotin]

Also, the "Add a backslash before '$'" solution is fine to me

[shockey]

Yeah, perhaps we should just be using an escape library (a la shell-escape).

Conveniently, we do build up an args array in our curlify function:

swagger-ui/src/core/curlify.js

Lines 4 to 9 in 9ea7fd9

	let curlified = []
	let type = ""
	let headers = request.get("headers")
	curlified.push( "curl" )
	curlified.push( "-X", request.get("method") )
	curlified.push( `"${request.get("url")}"`)