Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem with required boolean as operation parameter reappeared #6429

Closed
beatfreaker opened this issue Sep 23, 2020 · 0 comments · Fixed by #6449
Closed

Problem with required boolean as operation parameter reappeared #6429

beatfreaker opened this issue Sep 23, 2020 · 0 comments · Fixed by #6449
Assignees
@tim-lai
Labels
cat: try-it-out type: bug type: regression

Comments

@beatfreaker
Copy link

Q&A (please complete the following information)

  • OS: Windows
  • Browser: Chrome
  • Version: 85
  • Method of installation:
  • Swagger-UI version: 3.14.1
  • Swagger/OpenAPI version:

Describe the bug you're encountering

Facing issue with boolean fields reported @ (#4621)[https://github.com//issues/4612] again.

To reproduce...

Steps to reproduce the behavior:

  1. Open the operation
  2. Click try me out
  3. Leave the values as their original values then click execute
  4. The required field now turns red
  5. Select true in the required field then click execute
  6. The required field is still red
  7. select false in the required field
  8. select true in the required field then click execute
  9. This now works

Expected behavior

Execute operation should not give validation error if there is a default selected value.

Screenshots

Gv185PbNEK
tim-lai added a commit to tim-lai/swagger-ui that referenced this issue Sep 30, 2020
@tim-lai
fix(try-it-out): required boolean default value set to --
939037c 
ref: swagger-api#6429
@tim-lai tim-lai mentioned this issue Sep 30, 2020
Merged
17 tasks
tim-lai added a commit that referenced this issue Sep 30, 2020
@tim-lai
fix(try-it-out): required boolean default value set to empty string (#…
f5c709f 
…6449)

ref: #6429

* fix(try-it-out): required boolean default value set to empty string
* test(try-it-out): required enum and boolean fields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tim-lai tim-lai

Labels
cat: try-it-out type: bug type: regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(try-it-out): required boolean default value set to empty string tim-lai/swagger-ui
3 participants
@beatfreaker @hkosova @tim-lai