Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide minimum webpack@5 example that can build latest SwaggerUI/swagger-ui-react #7910

Closed
char0n opened this issue Mar 14, 2022 · 5 comments
Assignees
Labels
cat: documentation dependencies Pull requests that update a dependency file

Comments

@char0n
Copy link
Member

char0n commented Mar 14, 2022

Having minimum webpack@5 config, it can help also people with different build systems like rollup or esbuild.

@char0n char0n self-assigned this Mar 14, 2022
@char0n char0n added cat: documentation dependencies Pull requests that update a dependency file labels Mar 14, 2022
@piotrekwitkowski
Copy link

piotrekwitkowski commented Mar 15, 2022

Adding my 0.02$: it's not always the case that devs have access to any bundler's config. If modifying config is necessary, then, for example:

Providing users with config copy-paste bits seems bad from the UX perspective.
Instead of writing documentation on how to fix the symptoms, why not remove the cause and make swagger-ui work out-of-the-box without node polyfills that must be configured manually?

@scottohara
Copy link
Contributor

Possible duplicate of #7908

@char0n
Copy link
Member Author

char0n commented Mar 26, 2022

@piotrekwitkowski you're right. I've issued #7946 that addresses the problem. After merging the PR, SwaggerUI will work out of the box with CRA@{4,5} and should work with ng build as well. Thanks for bringing different way of thinking into this problem.

@piotrekwitkowski
Copy link

Great news! Looking forward to see this shipped and finally be unblocked! :)

char0n added a commit that referenced this issue Mar 28, 2022
@char0n
Copy link
Member Author

char0n commented Mar 28, 2022

@char0n char0n closed this as completed Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat: documentation dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

3 participants