New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Goodbye CoffeeScript! #1027
Merged
Merged
Goodbye CoffeeScript! #1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file is not fully converted. Some methods (mostly long ones) are brought from compiled CS code
Append all views to SwaggerUi.Views object
Doc.js is ignored in JSHint so we are not cleaning it up entirely!
🎊 🎉 |
vincent-zurczak
pushed a commit
to roboconf/swagger-ui
that referenced
this pull request
Aug 18, 2016
Goodbye CoffeeScript!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OperationView
class, some methods were too large to hand-code from scratch without making sure there is no code slips. The JavaScript generated by CoffeeScript compiler is used. There are comments in the file indicating that. We should refactor those large methods in the long run.SwaggerUi
object in a separate PR. Then we can add JSHint and possibly JSCS as part of build process.template
functions that were returning only a value.