Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goodbye CoffeeScript! #1027

Merged
merged 25 commits into from Mar 13, 2015
Merged

Goodbye CoffeeScript! #1027

merged 25 commits into from Mar 13, 2015

Conversation

mohsen1
Copy link
Contributor

@mohsen1 mohsen1 commented Mar 12, 2015

  • All CoffeeScript files are translated to JavaScript
  • in OperationView class, some methods were too large to hand-code from scratch without making sure there is no code slips. The JavaScript generated by CoffeeScript compiler is used. There are comments in the file indicating that. We should refactor those large methods in the long run.
  • Removed CoffeeScript from build task
  • Introduced JSHint although as of now it's not passing all the tests because there are too many globals. I didn't want to add all those globals to JSHint config file and instead I want to namespace all Views under SwaggerUi object in a separate PR. Then we can add JSHint and possibly JSCS as part of build process.
  • When rewriting files, I cleaned up some unnecessary code. Notably template functions that were returning only a value.
  • Tests are passing on my machine.

@mohsen1 mohsen1 added this to the v2.1-M2 milestone Mar 12, 2015
Append all views to SwaggerUi.Views object
Doc.js is ignored in JSHint so we are not cleaning it up entirely!
fehguy added a commit that referenced this pull request Mar 13, 2015
@fehguy fehguy merged commit 465436a into swagger-api:develop_2.0 Mar 13, 2015
@webron
Copy link
Contributor

webron commented Mar 13, 2015

🎊 🎉

vincent-zurczak pushed a commit to roboconf/swagger-ui that referenced this pull request Aug 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants