Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CurlHack #1315

Merged
merged 10 commits into from Jun 4, 2015
Merged

CurlHack #1315

merged 10 commits into from Jun 4, 2015

Conversation

shawngong
Copy link
Contributor

This allows curl output to be shown when the user clicks "try it now" in swagger UI.

Set it up in the "dist" folder to provide an easy demo of how it works.

Should be helpful for issue 1073.

@earth2marsh
Copy link
Contributor

@shawngong
Copy link
Contributor Author

I will look into that! Was not aware of it until now.

Edit: Rewrote the hack using asCurl

@webron
Copy link
Contributor

webron commented Jun 3, 2015

@shawngong - can you please rebase? We're running through the open PRs in the next couple of days.

@shawngong
Copy link
Contributor Author

@webron Done rebasing, there were no conflicts.

@webron
Copy link
Contributor

webron commented Jun 3, 2015

Well, there are conflicts unfortunately. Can't be merged automatically. We'll have to look into it.

@shawngong
Copy link
Contributor Author

@webron Thank you.

@fehguy fehguy merged commit 1ef90c4 into swagger-api:develop_2.0 Jun 4, 2015
@Smolations
Copy link

I just noticed that bootstrap was included in the libs in develop_2.0 so I went looking for the PR that added it, and here it is. Unfortunately, I cannot see where bootstrap is being used. There is no script tag loading it in index.html and the gulpfile doesn't seem to indicate that it gets bundled with anything. Can someone clarify?

cc/ @shawngong @webron

@shawngong
Copy link
Contributor Author

@Smolations Thanks for the catch! Yes that is entirely my fault, I accidentally added bootstrap when it was not being used. If someone with write access could remove it that would be much appreciated.

@webron
Copy link
Contributor

webron commented Jun 4, 2015

@shawngong - just submit a quick PR

@shawngong
Copy link
Contributor Author

@webron Okay done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants