Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validator's https detection #1427

Merged

Conversation

lucian303
Copy link
Contributor

This will make the URL's protocol correct, but it does not fix the issue that https://online.swagger.io/validator redirects to http://online.swagger.io/validator which returns an insecure image, breaking the nice green https logo in chrome.

fehguy added a commit that referenced this pull request Jul 23, 2015
@fehguy fehguy merged commit 958e748 into swagger-api:develop_2.0 Jul 23, 2015
@webron webron added this to the v2.1.1 milestone Jul 31, 2015
@danlangford
Copy link

just out of curiosity can i ask why we dont just do
this.model.validatorUrl = '//online.swagger.io/validator';
and allow the browser to maintain the current protocol?

doesnt matter. im here looking for anything around the redirection you mentioned. that redirect from https:// to http:// is really bugging me :-)

cheerio

@lucian303
Copy link
Contributor Author

Yeah, seems like a good solution to me.

On Aug 14, 2015 6:16 PM, "dan L" notifications@github.com wrote:

just out of curiosity can i ask why we dont just do
this.model.validatorUrl = '//online.swagger.io/validator';
and allow the browser to maintain the current protocol?

doesnt matter. im here looking for anything around the redirection you
mentioned. that redirect from https:// to http:// is really bugging me :-)

cheerio


Reply to this email directly or view it on GitHub.

vincent-zurczak pushed a commit to roboconf/swagger-ui that referenced this pull request Aug 19, 2016
…s-detection

Fix validator's https detection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants