Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't use ES6 syntax in a dist package #3264

Merged
merged 1 commit into from Jun 20, 2017
Merged

Conversation

konqi
Copy link
Contributor

@konqi konqi commented Jun 20, 2017

using ES6 syntax will cause trouble unless you transpile before use (which is something you should not be required to do in a dist package)

using ES6 syntax will cause trouble unless you transpile before use (which is something you should not be required to do in a dist package)
@webron webron requested a review from shockey June 20, 2017 17:47
@shockey
Copy link
Contributor

shockey commented Jun 20, 2017

Arrow functions are well-supported (see here and here)

.....except for IE11.

So this is a good catch. Thanks @konqi!

@shockey shockey merged commit c0a7003 into swagger-api:master Jun 20, 2017
@konqi
Copy link
Contributor Author

konqi commented Jun 20, 2017

I actually had trouble importing the module with webpack. It complained that the brackets () are not expected where they are. My guess is that it's a strict eslint rule that disallows arrow functions for compatibility reasons - so yeah - blame it on IE ;-)

@konqi konqi deleted the patch-1 branch June 20, 2017 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants