Bug fix for #3136 - Update state when scheme options change #3295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ously selected option is no longer available
|
@owenconti, we ended up in parallel universes 😱 see #3317 and #3166. I agree with you on keeping the logic in the reducer, but my changes ended up having logic in FYI: I kept your implementation of the method since it's more verbose. |
shockey
approved these changes
Jun 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3136 - Update 'selected' operation scheme when the options change and the previously selected scheme is no longer available.
Ideally, I'd prefer if this were done entirely in the reducer (on
UPDATE_SPEC), but I couldn't find an async action example. That being said, since a similar method of updating state is done in 'scomponentWillMount, I figured updating via the component would be okay. Please let me know if that assumption is incorrect.