Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing CORS header in request #3481

Merged
merged 4 commits into from Aug 3, 2017
Merged

Removing CORS header in request #3481

merged 4 commits into from Aug 3, 2017

Conversation

domanchi
Copy link
Contributor

@domanchi domanchi commented Jul 28, 2017

Description

The Access-Control-Allow-Origin header is sent by the server, to specify the allowed domains that can execute cross-domain requests. However, this is sending it in the request.

Three reasons to get rid of it:

  1. It's currently breaking CORS.
  2. It's not supposed to be sent in the request.
  3. swagger-client does it too.

@shockey
Copy link
Contributor

shockey commented Aug 2, 2017

Related issue: #3367

@bodnia
Copy link
Contributor

bodnia commented Aug 3, 2017

@domanchi could you please update your branch to latest master and this pr will be merged. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants