Array description should be processed as Markdown. #3531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhw
commented
Aug 7, 2017
| properties.size ? properties.entrySeq().map( ( [ key, v ] ) => <span key={`${key}-${v}`} style={ propStyle }> | ||
| <br />{ key }: { String(v) }</span>) | ||
| : null | ||
| } |
There was a problem hiding this comment.
Note that this removes a wrapping span from the previously generated markup. It makes it consistent with primitive-model.jsx though, and appears to have no visible side effects.
|
Markdown in model descriptions has limited utility due to the way we're styling descriptions... for example, all the text has a high font weight and is italicized, so bold/italic Markdown has no effect. This PR lets us parse the Markdown correctly, though - so it's good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Markdown rendering for array descriptions. Addresses part of #2745, and related to #3236.