Add defaultModelRendering parameter. #3628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shockey - the functionality is fine |
shockey
approved these changes
Sep 29, 2017
There was a problem hiding this comment.
Thanks for this, @gilbode! The functionality appears to work well.
The only problem I saw here is that setting defaultModelExpandDepth via query string does not work, since everything from the query string parse is a string value. We'll say that's out of scope for this PR, and address it as part of #3302. It's my view that the config parser should do the type conversions, config consumers shouldn't know/care about the particulars of URL query strings.
|
CC: #3302 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swagger UI 2.x had a defaultModelRendering parameter, this resurrects that parameter and also adds a defaultModelExpandDepth parameter so you can configure the default expandDepth of models.