Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/3474 #3647

Merged
merged 6 commits into from
Sep 29, 2017
Merged

Bug/3474 #3647

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7a4ef07
Merge remote-tracking branch 'refs/remotes/swagger-api/master'
JoshuaWhatley Sep 8, 2017
63ee0a8
break path if it would otherwise overflow
JoshuaWhatley Sep 8, 2017
82b9341
Changing word-break to follow standard
JoshuaWhatley Sep 14, 2017
6488cbb
Merge branch 'master' into bug/3474
JoshuaWhatley Sep 18, 2017
14f4765
Merge branch 'master' into bug/3474
JoshuaWhatley Sep 21, 2017
c5534a5
Merge branch 'master' into bug/3474
shockey Sep 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/style/_layout.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,8 +252,11 @@
font-size: 16px;

display: flex;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why display: flex was removed? AFAIK, the flex property doesn't implicitly trigger display: flex on the element.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The flex context is enabled via its direct parent and I didn't see a reason for the context to be passed further down to its children. So I removed it as unnecessary. It does no harm to keep it, if you foresee a future need for it.

flex: 0 3 auto;
align-items: center;

word-break: break-all;

padding: 0 10px;

@include text_code();
Expand Down