Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #3633 - PrimitiveModel titles #3676

Merged
merged 5 commits into from Sep 20, 2017
Merged

Fixes #3633 - PrimitiveModel titles #3676

merged 5 commits into from Sep 20, 2017

Conversation

owenconti
Copy link
Contributor

Fixes #3633

  • Fix alignment in array-model for properties
  • Increase fix width in property names and change units to em
  • Fix fallback to name prop in PrimitiveModel and add enzyme test

screen shot 2017-09-17 at 9 31 07 am

@owenconti
Fix property key: value alignment in array-model
0828220
@owenconti
Slightly increase size available for property names. Change units to …
b855c25 
…`em` and add a margin to separate the property name from the property type.
@owenconti
Remove .only from utils test
f63f022
@owenconti
Fixes #3633
44ece46 
Make sure PrimitiveModel uses the schema's title first and then falls back to the passed-in `name` property. Added enzyme test for functionality.
@shockey
Copy link
Contributor

shockey commented Sep 20, 2017

Thanks for catching my describe.only on that test.... We should set up eslint to prevent that 😄

@shockey shockey merged commit 6d67c6d into swagger-api:master Sep 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shockey shockey shockey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong model titles for primitive datatypes
2 participants
@owenconti @shockey