Fix auth icon display regression #3755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was messing up my editor's syntax highlighting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @webron, we discussed this earlier today.
This PR fixes a problem with our authSelector wrapActions in the OAS3 plugin, which was causing bleed into Swagger2 usage.
This has to do with interaction between complex action creators (with the signature
(...args) => (system) => action) and wrapActions. State is being provided to these original actions based on their signature, which creates an undocumented function signature in the wrapAction that sits atop it.I've made a TODO for myself in #3754 to document the correct way to go about this before shipping our new docs.