Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3714: Update react-collapse and react-motion for React 16 support #3880

Conversation

legrego
Copy link
Contributor

@legrego legrego commented Nov 8, 2017

Description

Updated versions of react-motion and react-collapse to be compatible with both React 15 & React 16

Motivation and Context

Fixes #3714

How Has This Been Tested?

After updating these versions, I tested using the petstore sample as-is, to confirm that it still worked with React 15.

I then tested this in a React 16 based project, and verified that I could use swagger-ui in this context, without receiving the proptype errors described in #3714

Screenshots (if appropriate):

N/A

Types of changes

  • No code changes (changes to documentation, CI, metadata, etc)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x ] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • [x ] All new and existing tests passed.

@webron webron requested a review from shockey November 8, 2017 23:19
@shockey shockey merged commit 4fa4e0f into swagger-api:master Nov 9, 2017
@shockey
Copy link
Contributor

shockey commented Nov 9, 2017

Thanks, @legrego!

@legrego legrego deleted the ft/3714-dependencies-not-compatible-with-React-16 branch November 9, 2017 12:17
@legrego legrego restored the ft/3714-dependencies-not-compatible-with-React-16 branch November 12, 2017 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependencies are not compatible with React 16
2 participants