Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #3571 - add polyfill for startsWith function for IE11. #3930

Merged
merged 1 commit into from Nov 20, 2017
Merged

Fixes #3571 - add polyfill for startsWith function for IE11. #3930

merged 1 commit into from Nov 20, 2017

Conversation

floriantraber
Copy link
Contributor

Motivation and Context

Fixes #3571

How Has This Been Tested?

Tested with https://raw.githubusercontent.com/OAI/OpenAPI-Specification/master/examples/v3.0/petstore.yaml in IE 11

Screenshots (if appropriate):

Types of changes

  • No code changes (changes to documentation, CI, metadata, etc)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@craigjbass
Copy link

Hey - what's outstanding to get this released?

@craigjbass craigjbass mentioned this pull request Nov 20, 2017
Closed
@webron webron requested a review from shockey November 20, 2017 17:45
@webron
Copy link
Contributor

webron commented Nov 20, 2017

@craigjbass you know, the usual process. Review, merge, release. The PR has been submitted 2 days ago, it's not pending for months.

shockey
shockey approved these changes Nov 20, 2017
View reviewed changes
Copy link
Contributor

@shockey shockey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shockey shockey merged commit cfc7b1a into swagger-api:master Nov 20, 2017
@shockey
Copy link
Contributor

shockey commented Nov 20, 2017

Thanks, @floriantraber!

@craigjbass
Copy link

@webron didn't mean my comments in a negative way. 👍 just wanted to provide help if necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shockey shockey shockey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OAS 3.0 doesn't render in IE11, failing to find startsWith function
4 participants
@floriantraber @craigjbass @webron @shockey