Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth modal close button addded #3939

Merged
merged 2 commits into from Nov 21, 2017
Merged

Auth modal close button addded #3939

merged 2 commits into from Nov 21, 2017

Conversation

Minasokoni
Copy link
Contributor

Description

Added a Done button to the auth modal

Motivation and Context

for #3537

Types of changes

  • No code changes (changes to documentation, CI, metadata, etc)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

shockey
shockey approved these changes Nov 21, 2017
View reviewed changes
Copy link
Contributor

@shockey shockey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shockey shockey merged commit 4f13d6d into master Nov 21, 2017
@shockey shockey mentioned this pull request Nov 21, 2017
Closed
@shockey shockey deleted the ft/authmodelclosebtn branch November 30, 2017 05:29
@charlescapps charlescapps mentioned this pull request Feb 10, 2018
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shockey shockey shockey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Minasokoni @shockey