Fix deeplinking for topbar plugin #4181
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable deeplinking with the topbar plugin.
Description
Following zyv's workaround I added some logic to change the
location.search
property on spec change. It's a bit of a hack though.Motivation and Context
Fixes #3649
How Has This Been Tested?
I haven't found any automated test for the topbar plugin unfortunately.
I have a branch with a modified version of the
index.html
used for dev where I tested it manually.I also added a couple of tests around parsing and serialization of
window.location.search
.Checklist
My PR contains...
src/
is unmodified: changes to documentation, CI, metadata, etc.)package.json
)My changes...
Documentation
Automated tests