Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply css only on first child label and span for section header #4970

Merged
merged 2 commits into from
Nov 23, 2018

Conversation

soullivaneuh
Copy link
Contributor

@soullivaneuh soullivaneuh commented Oct 25, 2018

Description

To ensure it does not modify other span and label design

Motivation and Context

This bugfix is needed because it breaks other application that may be used inside swagger.

In my case, the select2 rendering was broken because of the using of multiple span elements.

How Has This Been Tested?

I just changed the two lines and tested on my browser.

Screenshots (if appropriate):

Before (with select2):

image

After:

image

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@shockey
Copy link
Contributor

shockey commented Oct 25, 2018

please build

@soullivaneuh
Copy link
Contributor Author

@shockey What do you mean? I just did a quick edit from the GitHub editor.

@shockey
Copy link
Contributor

shockey commented Oct 26, 2018

oh, apologies @soullivaneuh - please build is a trigger phrase that tells the automated tests to run again! sorry for the confusion 😄

@soullivaneuh
Copy link
Contributor Author

@shockey Build is passing. Could you please merge it and release a bug fix? :-)

@soullivaneuh
Copy link
Contributor Author

@shockey Anything else to do to get this merged?

@shockey shockey merged commit 88e2c9a into swagger-api:master Nov 23, 2018
@shockey
Copy link
Contributor

shockey commented Nov 23, 2018

all good @soullivaneuh! thanks for the contribution 👍

@soullivaneuh soullivaneuh deleted the patch-1 branch November 29, 2018 14:39
@soullivaneuh
Copy link
Contributor Author

Glad to see this merged, thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants