Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix issue #5040 #5041

Merged
merged 8 commits into from
Nov 23, 2018
Merged

bugfix: fix issue #5040 #5041

merged 8 commits into from
Nov 23, 2018

Conversation

wrightkris
Copy link
Contributor

Description

Generated curl command for multipart/form-data file will not include a blank 'type' which causes curl to be invalid

Motivation and Context

Fixes #5040

How Has This Been Tested?

Added unit test. Local run against petstore swagger def.

Screenshots (if appropriate):

image

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@shockey shockey merged commit a40edea into swagger-api:master Nov 23, 2018
@shockey
Copy link
Contributor

shockey commented Nov 23, 2018

thanks @wrightkris!

@wrightkris wrightkris deleted the bug/5040 branch November 26, 2018 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

invalid curl command generated for unknown file types
2 participants