Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: expanding model when query param showExtensions=true exists #5918

Merged
merged 5 commits into from Mar 16, 2020

Conversation

tim-lai
Copy link
Contributor

@tim-lai tim-lai commented Mar 13, 2020

Description

In the ObjectModel, insert a table cell td into the table row tr. Then insert empty space   into the table cell.

Motivation and Context

  1. load SwaggerUI in dev mode
  2. use 2 query parameters, e.g. http://localhost:3200/?docExpansion=full&showExtensions=true
  3. expand any model
  4. console error
warning.js:33 Warning: validateDOMNesting(...): Whitespace text nodes cannot appear as a child of <tr>.

How Has This Been Tested?

Following the above steps no longer produces the error with this fix

Screenshots (if appropriate):

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@tim-lai tim-lai requested review from shockey and webron March 13, 2020 17:24
@tim-lai tim-lai changed the title Bug/show extensions bug: expanding model when query param showExtensions=true exists Mar 13, 2020
@tim-lai
Copy link
Contributor Author

tim-lai commented Mar 13, 2020

please build

Copy link
Contributor

@shockey shockey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from the unrelated changes included in model.jsx — please resolve before merging this!

@@ -5,7 +5,7 @@ import PropTypes from "prop-types"

export default class Model extends ImmutablePureComponent {
static propTypes = {
schema: ImPropTypes.orderedMap.isRequired,
schema: ImPropTypes.map.isRequired,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

likewise, looks like #5914 snuck in here!

@tim-lai tim-lai merged commit c30862e into swagger-api:master Mar 16, 2020
@tim-lai tim-lai deleted the bug/showExtensions branch May 15, 2020 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants