Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase bundle size limit to 1.1 MiB #7018

Merged
merged 5 commits into from
Mar 3, 2021

Conversation

mathis-m
Copy link
Contributor

@mathis-m mathis-m commented Mar 2, 2021

Description

Ensure future features have room.
#6910 (comment)

Motivation and Context

Fixes builds of #6910 and #6851

How Has This Been Tested?

Screenshots (if appropriate):

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

Signed-off-by: mathis-m <mathis.michel@outlook.de>
Copy link
Contributor

@tim-lai tim-lai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mathis-m 1.5 MiB is a big change, ~50% increase. Let's try 1.1 MiB / 11534336 instead.

webpack/_config-builder.js Outdated Show resolved Hide resolved
webpack/_config-builder.js Outdated Show resolved Hide resolved
mathis-m and others added 3 commits March 3, 2021 20:25
Co-authored-by: Tim Lai <timothy.lai@gmail.com>
Co-authored-by: Tim Lai <timothy.lai@gmail.com>
@mathis-m mathis-m changed the title increase bundle size limit to 1.5 MiB increase bundle size limit to 1.1 MiB Mar 3, 2021
@tim-lai tim-lai merged commit 0f092e5 into swagger-api:master Mar 3, 2021
@tim-lai
Copy link
Contributor

tim-lai commented Mar 3, 2021

@mathis-m PR merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants