Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(syntax-highlight): fix of fix that caused highlight code scrolling errors #7553

Closed

Conversation

mathis-m
Copy link
Contributor

@mathis-m mathis-m commented Oct 12, 2021

@char0n

Description

#7519 voiding the preventScroll handler as SyntaxHighlighter does not provide ref support.
#7551 fixes extensability of plugin SyntaxHighlighter
Refs #7552

Motivation and Context

Fixes #7497
Fixes #7519 voiding the preventScroll handler

How Has This Been Tested?

browser

Screenshots (if appropriate):

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@mathis-m mathis-m marked this pull request as draft October 12, 2021 16:16
@char0n
Copy link
Member

char0n commented Oct 12, 2021

LGTM, we'll base this on #7554 after out of v4

@char0n char0n self-requested a review October 12, 2021 17:48
@char0n char0n self-assigned this Oct 12, 2021
@tim-lai
Copy link
Contributor

tim-lai commented Mar 31, 2022

@mathis-m Closing this PR, as I think combination of #7554 and #7941 resolves the issue. If something got missed, please feel free to open a new PR, thanks!

@tim-lai tim-lai closed this Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants