Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(plugins): expose JSON Schema merging mechanism from samples plugins #9766

Merged
merged 2 commits into from
Mar 29, 2024
Merged

feat(plugins): expose JSON Schema merging mechanism from samples plugins #9766

merged 2 commits into from
Mar 29, 2024

Conversation

glowcloud
Copy link
Contributor

Refs #9765

@glowcloud glowcloud requested a review from char0n March 29, 2024 10:16
@glowcloud glowcloud self-assigned this Mar 29, 2024
char0n
char0n approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@char0n char0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes looks good! Nicely done.

Please process my naming CR comments before merging.

@char0n char0n changed the title feat(plugins): expose mergeJsonSchema function from JSON schema samples feat(plugins): expose JSON Schema merging mechanism from samples plugins Mar 29, 2024
@glowcloud glowcloud merged commit 6a493fb into master Mar 29, 2024
8 checks passed
@glowcloud glowcloud deleted the issue-9765 branch March 29, 2024 11:56
@glowcloud glowcloud mentioned this pull request Mar 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@char0n char0n char0n approved these changes

Assignees

@glowcloud glowcloud

Labels
cat: plugins type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@glowcloud @char0n