-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore relationships that don't have data property #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @pdw-mb, You're right. According to the https://jsonapi.org/format/#document-resource-object-relationships, one of |
char0n
added a commit
that referenced
this pull request
Feb 22, 2023
Added test for asserting that json-api-merge throws error on the case you described: #788 |
char0n
added a commit
that referenced
this pull request
Feb 22, 2023
char0n
reviewed
Feb 22, 2023
I've fixed linting issue + changed the test to verify your change. |
Thanks for contributing. |
char0n
pushed a commit
that referenced
this pull request
Feb 22, 2023
## [1.1.4](v1.1.3...v1.1.4) (2023-02-22) ### Bug Fixes * ignore relationships that don't have data property ([#778](#778)) ([65f0daa](65f0daa))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using json-api-merge on a request that only has some relationships included, so I have data that looks like this:
Note the lack of
data
property onvalidation_messages
. json-api-merge currently breaks on this input. This PR filters relationships to those which contain thedata
property.