Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize marshal #22

Merged
merged 5 commits into from
Jan 26, 2020
Merged

Optimize marshal #22

merged 5 commits into from
Jan 26, 2020

Conversation

vearutop
Copy link
Member

Added

  • Early return in MarshalJSON if there are no additional properties to improve performance.
  • JSON Schema maker library updated.

@codecov
Copy link

codecov bot commented Jan 26, 2020

Codecov Report

Merging #22 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #22      +/-   ##
===========================================
+ Coverage     81.31%   81.4%   +0.09%     
- Complexity      742     745       +3     
===========================================
  Files            43      43              
  Lines          1846    1855       +9     
===========================================
+ Hits           1501    1510       +9     
  Misses          345     345
Impacted Files Coverage Δ Complexity Δ
src/JsonSchema/MarshalJson.php 100% <100%> (ø) 72 <0> (+3) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f9a579...763cb1f. Read the comment docs.

@vearutop vearutop merged commit e0210fb into master Jan 26, 2020
@vearutop vearutop deleted the marshal branch January 26, 2020 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant