Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support swagger configuration #48

Merged
merged 3 commits into from
Mar 24, 2019

Conversation

pei0804
Copy link
Member

@pei0804 pei0804 commented Mar 23, 2019

Reverts #47
#46 (comment)

@codecov-io
Copy link

codecov-io commented Mar 23, 2019

Codecov Report

Merging #48 into master will increase coverage by 1.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
+ Coverage   94.11%   95.23%   +1.12%     
==========================================
  Files           1        1              
  Lines          34       42       +8     
==========================================
+ Hits           32       40       +8     
  Misses          1        1              
  Partials        1        1
Impacted Files Coverage Δ
swagger.go 95.23% <100%> (+1.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acdcd7f...e22d4ea. Read the comment docs.

@pei0804 pei0804 force-pushed the revert-47-revert-46-support-config-api-definition branch from 96695cc to 988b92a Compare March 23, 2019 12:18
@pei0804 pei0804 changed the title [WIP]feat: support swagger configuration feat: support swagger configuration Mar 23, 2019
@pei0804
Copy link
Member Author

pei0804 commented Mar 23, 2019

@easonlin404
I do it.

Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@easonlin404 easonlin404 merged commit db2fafd into master Mar 24, 2019
@easonlin404 easonlin404 deleted the revert-47-revert-46-support-config-api-definition branch March 24, 2019 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants