Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

root level accept/produce params #1011

Merged
merged 2 commits into from
Oct 3, 2021
Merged

root level accept/produce params #1011

merged 2 commits into from
Oct 3, 2021

Conversation

ubogdan
Copy link
Contributor

@ubogdan ubogdan commented Sep 29, 2021

Describe the PR
add root level @accept @produce to help on reducing boilerplate.

Relation issue
#887

Additional context
None.

@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #1011 (6fe3a11) into master (f9645be) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1011      +/-   ##
==========================================
+ Coverage   93.21%   93.25%   +0.04%     
==========================================
  Files           7        7              
  Lines        1931     1943      +12     
==========================================
+ Hits         1800     1812      +12     
  Misses         73       73              
  Partials       58       58              
Impacted Files Coverage Δ
operation.go 95.10% <100.00%> (ø)
parser.go 93.48% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9645be...6fe3a11. Read the comment docs.

@ubogdan
Copy link
Contributor Author

ubogdan commented Oct 2, 2021

@sdghchj, please give me a hand with a review here.

@ubogdan ubogdan merged commit 9fb19d0 into master Oct 3, 2021
@ubogdan ubogdan deleted the root_level_accept_produce branch October 3, 2021 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant