Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto parse external models when flag parseDependency is set #1027

Merged
merged 4 commits into from
Oct 14, 2021

Conversation

sdghchj
Copy link
Member

@sdghchj sdghchj commented Oct 14, 2021

Describe the PR
Auto parse external models when flag parseDependency is set

Relation issue
#808

@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #1027 (920a43d) into master (271d4d2) will decrease coverage by 0.33%.
The diff coverage is 75.34%.

❗ Current head 920a43d differs from pull request most recent head 6b798c8. Consider uploading reports for the commit 6b798c8 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1027      +/-   ##
==========================================
- Coverage   93.34%   93.00%   -0.34%     
==========================================
  Files           7        7              
  Lines        1968     2002      +34     
==========================================
+ Hits         1837     1862      +25     
- Misses         73       77       +4     
- Partials       58       63       +5     
Impacted Files Coverage Δ
packages.go 76.79% <75.00%> (-0.76%) ⬇️
parser.go 93.48% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 271d4d2...6b798c8. Read the comment docs.

cmd/swag/main.go Outdated
Usage: "Parse go files in outside dependency folder, disabled by default",
Name: parseDependencyFlag,
Aliases: []string{"pd"},
Usage: "Parse go files in outside dependency folder, disabled by default",
Copy link
Contributor

@ubogdan ubogdan Oct 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rephrase suggestion:
"Parse the go files outside the dependency folder, disabled by default."

Copy link
Member Author

@sdghchj sdghchj Oct 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rephrase suggestion: "Parse the go files outside the dependency folder, disabled by default."

I guess it wants to express parsing the files in the dependency folder outside the current folder.

Copy link
Contributor

@ubogdan ubogdan Oct 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should say: "Parse the go files inside dependency folder, disabled by default."

The "in outside" is ambiguous phrasing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Copy link
Contributor

@ubogdan ubogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdghchj sdghchj merged commit 9981d9f into master Oct 14, 2021
@sdghchj sdghchj deleted the parse_external_models2 branch October 14, 2021 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants