Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text/plain allowed in request body #1029

Merged
merged 4 commits into from
Oct 20, 2021
Merged

text/plain allowed in request body #1029

merged 4 commits into from
Oct 20, 2021

Conversation

sdghchj
Copy link
Member

@sdghchj sdghchj commented Oct 15, 2021

Describe the PR
text/plain allowed in request body

Relation issue
#1020

@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #1029 (a67dbe7) into master (9981d9f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1029      +/-   ##
==========================================
+ Coverage   93.00%   93.01%   +0.01%     
==========================================
  Files           7        7              
  Lines        2002     2005       +3     
==========================================
+ Hits         1862     1865       +3     
  Misses         77       77              
  Partials       63       63              
Impacted Files Coverage Δ
operation.go 95.22% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9981d9f...a67dbe7. Read the comment docs.

@ubogdan
Copy link
Contributor

ubogdan commented Oct 15, 2021

Would you mind adding a test for this new implementation/fix?

@sdghchj
Copy link
Member Author

sdghchj commented Oct 20, 2021

Would you mind adding a test for this new implementation/fix?

Added

Copy link
Contributor

@ubogdan ubogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ubogdan ubogdan merged commit 0548f60 into master Oct 20, 2021
@ubogdan ubogdan deleted the text_plain_in_body branch October 20, 2021 05:59
@ubogdan
Copy link
Contributor

ubogdan commented Oct 20, 2021

@sdghchj Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants