Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Instance name func to doc file #1116

Merged
merged 6 commits into from Feb 2, 2022
Merged

Feature: Instance name func to doc file #1116

merged 6 commits into from Feb 2, 2022

Conversation

Ferrany1
Copy link
Contributor

Describe the PR
Feature: Instance name func to doc file

Relation issue
#1113

@codecov
Copy link

codecov bot commented Jan 30, 2022

Codecov Report

Merging #1116 (ecc08ec) into master (7137cd8) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1116      +/-   ##
==========================================
+ Coverage   94.61%   94.66%   +0.04%     
==========================================
  Files           9       10       +1     
  Lines        2379     2399      +20     
==========================================
+ Hits         2251     2271      +20     
  Misses         67       67              
  Partials       61       61              
Impacted Files Coverage Δ
gen/gen.go 93.33% <ø> (ø)
spec.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7137cd8...ecc08ec. Read the comment docs.

gen/gen.go Outdated Show resolved Hide resolved
Copy link
Contributor

@ubogdan ubogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job till now. Would you mind making some other minor adjustments according to the comments?

swagger_info.go Outdated Show resolved Hide resolved
gen/gen.go Show resolved Hide resolved
swagger_info.go Outdated Show resolved Hide resolved
Copy link
Contributor

@ubogdan ubogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ubogdan ubogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ubogdan ubogdan merged commit b1e10b7 into swaggo:master Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants