Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for go v1.17.x #1723

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Drop support for go v1.17.x #1723

merged 2 commits into from
Dec 18, 2023

Conversation

sdghchj
Copy link
Member

@sdghchj sdghchj commented Dec 18, 2023

Describe the PR
Remove go version v1.17.x

Relation issue
#1715
#1722

Signed-off-by: sdghchj <sdghchj@qq.com>
@sdghchj
Copy link
Member Author

sdghchj commented Dec 18, 2023

@ubogdan Do you know how to fix it ?
I wonder why it gets the latest go-openapi/spec version while v.0.20.4 is declared in go.mod?
I find it uses go get to upgrade deps in Makefile, why not use go mod tidy?

@sdghchj sdghchj changed the title Remove go v1.17.x Drop support for go v1.17.x Dec 18, 2023
@ubogdan
Copy link
Contributor

ubogdan commented Dec 18, 2023

Well, I guess the "deps" target from the Makefile is not needed anymore. Also, we use GOPATH in the workflow named ci.yaml (which is not necessary anymore).

Signed-off-by: sdghchj <sdghchj@qq.com>
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6cdaaf5) 83.52% compared to head (9d71a87) 83.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1723      +/-   ##
==========================================
- Coverage   83.52%   83.39%   -0.14%     
==========================================
  Files          19       16       -3     
  Lines        3823     3781      -42     
==========================================
- Hits         3193     3153      -40     
+ Misses        534      532       -2     
  Partials       96       96              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sdghchj sdghchj requested a review from ubogdan December 18, 2023 08:06
@sdghchj
Copy link
Member Author

sdghchj commented Dec 18, 2023

Well, I guess the "deps" target from the Makefile is not needed anymore. Also, we use GOPATH in the workflow named ci.yaml (which is not necessary anymore).

OK.
I have fixed it with go mod tidy.

@sdghchj sdghchj merged commit 744a58e into master Dec 18, 2023
12 checks passed
@sdghchj sdghchj deleted the remove_go_v1_17_x branch December 18, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants