Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate some parts of routers in an operation #1735

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

sdghchj
Copy link
Member

@sdghchj sdghchj commented Jan 10, 2024

Describe the PR
add @DeprecatedRouter to deprecate some parts of routers in an operation

Relation issue
#1733

Additional context

@Router                      /a [GET]
@DeprecatedRouter   /a/b [GET]

Signed-off-by: sdghchj <sdghchj@qq.com>
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (33da992) 83.18% compared to head (d5cb634) 83.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1735      +/-   ##
==========================================
+ Coverage   83.18%   83.20%   +0.02%     
==========================================
  Files          16       16              
  Lines        3806     3811       +5     
==========================================
+ Hits         3166     3171       +5     
  Misses        543      543              
  Partials       97       97              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sdghchj sdghchj requested a review from ubogdan January 10, 2024 06:18
Copy link
Contributor

@ubogdan ubogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdghchj sdghchj merged commit 0fb6820 into master Jan 11, 2024
12 checks passed
@sdghchj sdghchj deleted the deprecated_enhancement branch January 11, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants