Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Support generic with map params #1746

Merged
merged 3 commits into from
Jan 29, 2024
Merged

Conversation

sdghchj
Copy link
Member

@sdghchj sdghchj commented Jan 22, 2024

Describe the PR
Support generic with map params, especially, map and array can arbitrarily combine.
For example,


types.MyGeneric[map[string][][]string, []map[string][]string]

Relation issue
#1711

Signed-off-by: sdghchj <sdghchj@qq.com>
Signed-off-by: sdghchj <sdghchj@qq.com>
Signed-off-by: sdghchj <sdghchj@qq.com>
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (ae7e404) 83.33% compared to head (0dd8775) 83.40%.

Files Patch % Lines
generics.go 91.89% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1746      +/-   ##
==========================================
+ Coverage   83.33%   83.40%   +0.06%     
==========================================
  Files          16       16              
  Lines        3817     3868      +51     
==========================================
+ Hits         3181     3226      +45     
- Misses        541      544       +3     
- Partials       95       98       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sdghchj sdghchj requested a review from ubogdan January 23, 2024 01:26
@sdghchj sdghchj merged commit 7147984 into master Jan 29, 2024
12 checks passed
@sdghchj sdghchj deleted the generic_with_map_param branch January 29, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants