Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(refactor): improve code quality #540

Merged
merged 2 commits into from Oct 14, 2019
Merged

Conversation

ubogdan
Copy link
Contributor

@ubogdan ubogdan commented Oct 9, 2019

Describe the PR
Reduce code complexity in gen/gen.go and cmd/swag/main.go
Remove testdata generated docs garbage

Relation issue
NONE

Additional context
NONE

@ubogdan ubogdan requested a review from pei0804 October 9, 2019 18:43
@codecov-io
Copy link

codecov-io commented Oct 9, 2019

Codecov Report

Merging #540 into master will increase coverage by 0.29%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #540      +/-   ##
=========================================
+ Coverage    86.9%   87.2%   +0.29%     
=========================================
  Files           7       7              
  Lines        1550    1555       +5     
=========================================
+ Hits         1347    1356       +9     
+ Misses        119     117       -2     
+ Partials       84      82       -2
Impacted Files Coverage Δ
gen/gen.go 96.69% <100%> (+7.03%) ⬆️
parser.go 81.93% <0%> (-0.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9f403a...d8712fd. Read the comment docs.

@easonlin404 easonlin404 changed the title Improve code quality chore: Improve code quality Oct 14, 2019
@easonlin404 easonlin404 changed the title chore: Improve code quality chore(refactor): improve code quality Oct 14, 2019
@easonlin404 easonlin404 merged commit 008c37b into master Oct 14, 2019
@easonlin404 easonlin404 deleted the reduce-complexity branch October 14, 2019 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants