support []map #586
Merged
support []map #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #586 +/- ##
==========================================
+ Coverage 86.24% 86.36% +0.12%
==========================================
Files 7 7
Lines 1599 1614 +15
==========================================
+ Hits 1379 1394 +15
Misses 136 136
Partials 84 84
Continue to review full report at Codecov.
|
easonlin404
reviewed
Dec 23, 2019
| return parseFieldSelectorExpr(astTypeArrayExpr, parser, newArrayProperty) | ||
| } | ||
| if astTypeArrayExpr, ok := astTypeArray.Elt.(*ast.StarExpr); ok { | ||
| } else if astTypeArrayExpr, ok := astTypeArray.Elt.(*ast.StarExpr); ok { |
There was a problem hiding this comment.
This part of the code seems like a little messy. It should be refactored in a good way in the future.
easonlin404
approved these changes
Dec 23, 2019
There was a problem hiding this comment.
see https://github.com/swaggo/swag/pull/586/files#r360813927. Rest LGTM.
|
@sdghchj Thanks for your contributions. 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solve issue #584