Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the condition for checking custom arrayType #590

Merged
merged 2 commits into from Dec 25, 2019
Merged

change the condition for checking custom arrayType #590

merged 2 commits into from Dec 25, 2019

Conversation

sdghchj
Copy link
Member

@sdghchj sdghchj commented Dec 25, 2019

Describe the PR
Change the condition for checking custom arrayType, only if arrayType is specified by flag swaggertype

Relation issue
fix #558

@codecov-io
Copy link

codecov-io commented Dec 25, 2019

Codecov Report

Merging #590 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #590   +/-   ##
======================================
  Coverage    86.2%   86.2%           
======================================
  Files           7       7           
  Lines        1631    1631           
======================================
  Hits         1406    1406           
  Misses        141     141           
  Partials       84      84
Impacted Files Coverage Δ
parser.go 80.89% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10630b9...6d96dd1. Read the comment docs.

parser.go Outdated Show resolved Hide resolved
@easonlin404
Copy link
Member

easonlin404 commented Dec 25, 2019

others lgtm.

@easonlin404 easonlin404 merged commit 73e3f31 into swaggo:master Dec 25, 2019
@easonlin404
Copy link
Member

@sdghchj thanks for your contribution. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'swaggertype' tag doesn't work properly for pointer fields
3 participants