Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issues_592: Use of go primitive array type in body give error #593

Merged
merged 2 commits into from Dec 31, 2019
Merged

Fixed issues_592: Use of go primitive array type in body give error #593

merged 2 commits into from Dec 31, 2019

Conversation

erikfarhanmalik-ralali
Copy link
Contributor

Fixed Issue 592

@codecov-io
Copy link

codecov-io commented Dec 31, 2019 •
edited

Codecov Report

Merging #593 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #593      +/-   ##
==========================================
+ Coverage   86.01%   86.01%   +<.01%     
==========================================
  Files           7        7              
  Lines        1637     1638       +1     
==========================================
+ Hits         1408     1409       +1     
  Misses        144      144              
  Partials       85       85
Impacted Files Coverage Δ
operation.go 91.79% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 549622f...db20641. Read the comment docs.

@sdghchj
Copy link
Member

sdghchj commented Dec 31, 2019

oh, that's good

easonlin404
easonlin404 reviewed Dec 31, 2019
View reviewed changes
Copy link
Member

@easonlin404 easonlin404 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you help add tests case for it?

@erikfarhanmalik-ralali
Copy link
Contributor Author

Could you help add tests case for it?

Added.

sdghchj
sdghchj reviewed Dec 31, 2019
View reviewed changes
Copy link
Member

@sdghchj sdghchj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, however, it is better, I think, to merge it with L383 and L410.
Maybe next PR's work.

easonlin404
easonlin404 approved these changes Dec 31, 2019
View reviewed changes
Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@easonlin404 easonlin404 merged commit 8cedf42 into swaggo:master Dec 31, 2019
@easonlin404
Copy link
Member

Thanks for your contributions 👍

@erikfarhanmalik-ralali
Copy link
Contributor Author

Thanks for your contributions 👍

I'm more than happy to contribute. Thanks. :-)

@easonlin404 easonlin404 added the bug label Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdghchj sdghchj sdghchj left review comments

@easonlin404 easonlin404 easonlin404 approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use of go primitive array type in body give error
4 participants
@erikfarhanmalik-ralali @codecov-io @sdghchj @easonlin404