Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: extend struct's simple members in query comment #594

Merged
merged 2 commits into from Jan 3, 2020
Merged

feature: extend struct's simple members in query comment #594

merged 2 commits into from Jan 3, 2020

Conversation

sdghchj
Copy link
Member

@sdghchj sdghchj commented Jan 2, 2020

Describe the PR
Extend struct's simple members in query param, that is, allow struct type in query param comment.

Relation issue
#518

@codecov-io
Copy link

codecov-io commented Jan 2, 2020

Codecov Report

Merging #594 into master will decrease coverage by 0.07%.
The diff coverage is 80.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #594      +/-   ##
==========================================
- Coverage   86.01%   85.94%   -0.08%     
==========================================
  Files           7        7              
  Lines        1638     1693      +55     
==========================================
+ Hits         1409     1455      +46     
- Misses        144      149       +5     
- Partials       85       89       +4
Impacted Files Coverage Δ
schema.go 100% <100%> (ø) ⬆️
operation.go 90.77% <78.87%> (-1.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cedf42...a68c2ea. Read the comment docs.

@sdghchj sdghchj closed this Jan 2, 2020
optimize function registerSchemaType's return types.
@sdghchj sdghchj reopened this Jan 2, 2020
Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@easonlin404
Copy link
Member

@sdghchj Thanks to you for your effort in it. This is a useful feature. 👍 👍 👍

@easonlin404 easonlin404 merged commit 74d6d6c into swaggo:master Jan 3, 2020
@sdghchj
Copy link
Member Author

sdghchj commented Jan 3, 2020

@easonlin404 why still not publish v1.6.4?

@easonlin404
Copy link
Member

@easonlin404 why still not publish v1.6.4?

OK. I will release v1.6.4 in the next two days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants