New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip cgo package #662
Skip cgo package #662
Conversation
Codecov Report
@@ Coverage Diff @@
## master #662 +/- ##
==========================================
- Coverage 85.00% 84.90% -0.10%
==========================================
Files 7 7
Lines 1807 1809 +2
==========================================
Hits 1536 1536
- Misses 172 173 +1
- Partials 99 100 +1
Continue to review full report at Codecov.
|
Can you please add some tests for it. |
Hi, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had make the same change then fix the following issue
#674
As far as I understand from the fix, we are not interested in any struct declarations inside CGO packages? |
So big a sample just for cgo? |
Yes, I think would be too much problems to scan "cgo"... I think the purpose of cgo is only to use non-go libraries, not to expose directly native structs to json...
Copy/paste of simple ref example, just added some dummy cgo. |
I mean can you compress it after you copy/paste it? |
Hi,
What do you ben by "compress" ? Remove redundant files/code ? Or something more ? :) |
Remove redundant files/code. |
This reverts commit 070af50.
Just one gin router is enough. I think. |
I think I have it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Describe the PR
Swag tries to parse CGO packages, this PR adds a way to handle this.
Relation issue
#567