Add required docs to README.md #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no mention of the `validate` tag used for required fields in the docs, so I did my best to add one.
Codecov Report
@@ Coverage Diff @@
## master #703 +/- ##
=======================================
Coverage 84.77% 84.77%
=======================================
Files 7 7
Lines 1859 1859
=======================================
Hits 1576 1576
Misses 177 177
Partials 106 106 Continue to review full report at Codecov.
|
|
anything I can do to help get this merged? |
|
@sdowding-koho sorry for the late reply, LGTM. |
easonlin404
approved these changes
May 29, 2020
|
Thanks for your contribution. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
There is no mention of the
validatetag used for required fields in the docs, so I did my best to add one.Relation issue
None
Additional context
To help people who come after me!