Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix primitive type of param in body; use const string for type #734

Merged
merged 4 commits into from Jun 10, 2020

Conversation

sdghchj
Copy link
Member

@sdghchj sdghchj commented Jun 10, 2020

Fix a bug by last PR: wrong primitive type of param in body;
Use const string for type.

@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2020

Codecov Report

Merging #734 into master will decrease coverage by 0.09%.
The diff coverage is 86.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #734      +/-   ##
==========================================
- Coverage   84.58%   84.48%   -0.10%     
==========================================
  Files           7        7              
  Lines        1790     1792       +2     
==========================================
  Hits         1514     1514              
- Misses        171      173       +2     
  Partials      105      105              
Impacted Files Coverage Δ
operation.go 87.56% <76.19%> (-0.32%) ⬇️
parser.go 79.76% <88.46%> (ø)
property.go 91.66% <88.88%> (ø)
schema.go 96.82% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1868a02...865534c. Read the comment docs.

@easonlin404 easonlin404 self-requested a review June 10, 2020 17:17
Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@easonlin404 easonlin404 merged commit 4a18bc9 into master Jun 10, 2020
@easonlin404 easonlin404 deleted the refactor2 branch June 10, 2020 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants