Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace unsupported and vulnerable satori/go.uuid with gofrs/uuid #798

Merged
merged 1 commit into from Oct 4, 2020

Conversation

rootatdarkstar
Copy link
Contributor

@rootatdarkstar rootatdarkstar commented Oct 2, 2020

Describe the PR
Replace non-maintained and vulnerable satori/go.uuid with its successor - gofrs/uuid
https://github.com/satori/go.uuid

satori/go.uuid security issue:
https://snyk.io/vuln/SNYK-GOLANG-GITHUBCOMSATORIGOUUID-72488

Relation issue
#799

Additional context

@codecov
Copy link

codecov bot commented Oct 2, 2020

Codecov Report

Merging #798 into master will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #798      +/-   ##
==========================================
- Coverage   80.91%   80.79%   -0.13%     
==========================================
  Files           8        8              
  Lines        1588     1588              
==========================================
- Hits         1285     1283       -2     
- Misses        187      188       +1     
- Partials      116      117       +1     
Impacted Files Coverage Δ
parser.go 75.47% <0.00%> (-0.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33e4ac3...35c5c8a. Read the comment docs.

Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@easonlin404 easonlin404 merged commit 80b6894 into swaggo:master Oct 4, 2020
@easonlin404
Copy link
Member

@rootatdarkstar Thanks for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants