fix: honor x-order while sorting query parameters #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of always sorting parameters with name, which can surprise users because x-order is ignored, sort them with the slice type declared in github.com/go-openapi/spec to reuse its comparison method.
Codecov Report
@@ Coverage Diff @@
## master #806 +/- ##
==========================================
+ Coverage 82.33% 82.38% +0.04%
==========================================
Files 8 8
Lines 1608 1612 +4
==========================================
+ Hits 1324 1328 +4
Misses 168 168
Partials 116 116
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Instead of always sorting parameters with name, which can surprise users
because x-order is ignored, sort them with the slice type declared in
github.com/go-openapi/spec to reuse its comparison method.
Relation issue
#681
Additional context
It can be simplified if go-openapi/spec#117 is merged.