debug info should go to stdout instead of stderr #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #990 +/- ##
==========================================
+ Coverage 92.57% 93.19% +0.61%
==========================================
Files 8 7 -1
Lines 1925 1924 -1
==========================================
+ Hits 1782 1793 +11
+ Misses 80 73 -7
+ Partials 63 58 -5
Continue to review full report at Codecov.
|
ubogdan
requested review from
easonlin404,
pei0804 and
sdghchj
and removed request for
sdghchj
|
a CR will be much appreciated. 10x |
|
@easonlin404 should we forget about this feature? |
|
@sdghchj can you please give me a hand with a CR. |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
add support to set up a logger for the parser. The default one should write to stdout instead of stderr.
Relation issue
#929
Additional context
NONE