Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor using React & Typescript #1

Merged
merged 27 commits into from
Oct 14, 2021
Merged

Refactor using React & Typescript #1

merged 27 commits into from
Oct 14, 2021

Conversation

krishnan-r
Copy link
Contributor

@krishnan-r krishnan-r commented Aug 3, 2021 •
edited

Summary of Changes

  • Reimplemented the frontend using React+MobX & Typescript
  • Added support for Jupyter Notebook, using separate tsconfig & builds for notebook & lab from the same code
  • Implemented improvements from notebook extension here
    • Build JARS for scala 2.11 & 2.12
    • Fixes for Spark 3.x
    • Reduced logging
  • Updated python packaging to push to pypi as sparkmonitor once merged

@krishnan-r krishnan-r self-assigned this Aug 3, 2021
@krishnan-r krishnan-r changed the title Refactor using React & Typescript WIP: Refactor using React & Typescript Aug 3, 2021
@krishnan-r krishnan-r changed the base branch from master to fixes August 6, 2021 11:07
@krishnan-r krishnan-r changed the base branch from fixes to master August 17, 2021 08:20
@krishnan-r krishnan-r changed the title WIP: Refactor using React & Typescript Refactor using React & Typescript Aug 18, 2021
@krishnan-r krishnan-r marked this pull request as ready for review September 13, 2021 10:42
@krishnan-r krishnan-r mentioned this pull request Sep 14, 2021
Open
diocas
diocas reviewed Sep 19, 2021
View reviewed changes
Copy link
Contributor

@diocas diocas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So... this is almost a complete rewrite of the extension (in ts)? Nice!
When you said rewrite in TS I though it was only the lab extension, but reusing components makes total sense.
I didn't have the time to check the ts files, only the others, so this is a half review. I decided to submit it since I'm on holidays and won't be able to finish until 1 week from now.

I like the organization of the different extensions.
Please gitignore the jar outputs, as they were commited and shouldn't. You also don't build the jars when building the extension. Are these decisions on purpose?

Side note: what are we going to do with swan_spark_conf, which is the variable our users currently use? nvm!

README.md Show resolved Hide resolved
package.json Show resolved Hide resolved
sparkmonitor/__init__.py Outdated Show resolved Hide resolved
sparkmonitor/__init__.py Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
sparkmonitor/kernelextension.py Show resolved Hide resolved
@krishnan-r
Address review comments
c05ec7b 
- Update versioning to match `sparkmonitor` package on pypi
- Updated readme comments
- Remove makefile, commit hooks, tox, Dockerfile, and old requirements.txts
- Remove jar file from git
@krishnan-r
Copy link
Contributor Author

Thanks for the review @diocas,

  • I've removed the JARs from git, and added the commands to build them through setup.py and yarn run build:prod
  • I've added a CI for linting the frontend code, will do the backend as a separate PR
  • addressed the other comments

@krishnan-r krishnan-r mentioned this pull request Sep 30, 2021
Closed
@krishnan-r krishnan-r merged commit 50bdc90 into master Oct 14, 2021
@krishnan-r krishnan-r deleted the react-typescript-refactor branch October 14, 2021 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diocas diocas diocas approved these changes

@etejedor etejedor Awaiting requested review from etejedor

@rccern rccern Awaiting requested review from rccern

Assignees

@krishnan-r krishnan-r

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@krishnan-r @diocas