Skip to content

Loading…

More contributors #52

Open
jonnay opened this Issue · 9 comments

5 participants

@jonnay
swank-js member

I'm busy these days, and don't have much time and we need some more contributors. Apply within!

@jlongster

I've used swank-js off and on, and I really appreciate that it exists. The code seems pretty straight-forward and I've hacked on it a little bit to get it to work with projects that have a different structure. I might try to fix some bugs at some point but I can't promise much right now. I'm definitely interested in it sticking around though.

@jonnay
swank-js member

@ivan4th How do you feel about either adding jlongster or giving me admin access to the project? Thanks!

@ivan4th
swank-js member

@jonnay Added you to 'Owners' team.

@ivan4th
swank-js member

Added jlongster to developers.

@jonnay
swank-js member

Sweet! Thank you!

@jonnay jonnay closed this
@jlongster

Hey guys -- to be honest, I've got a ton on my plate and I'm getting by with swank.js right now, not sure I'll have time to dig in and fix stuff. Unfortunately I really only use it to refresh CSS on the fly. A lot of the javascript I work with is wrapped up in a require.js module, so it's completely inaccessible to the REPL, which makes me really sad. Until javascript gets proper modules, I don't think there's anything we can do about that.

Just letting you guys know that I won't be able to contribute much in the near future.

@jonnay
swank-js member

I think everyone is in that boat. C'est la vie!

@jonnay jonnay reopened this
@lazywithclass

Hi, I'm trying to fix what I think could be a bug, is there a way to run all the tests?
I'm working in completion.js, I thought about writing a test first but running node completion-tests.js gave me

'completion eval error: TypeError' is expected: completion eval error: TypeError: Cannot read property 'bar' of undefined

is there something I'm missing? Sorry if this sounds obvious, but I would like to contribute.

EDIT:

I just saw this commit: 390f0e1 and realized this is not a failing test.

@erjoalgo

I just made a pull request mainly to fix some deprecated functions. Please take a look at it. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.