More contributors #52

Open
jonnay opened this Issue Sep 21, 2012 · 9 comments

Comments

Projects
None yet
5 participants
@jonnay
Member

jonnay commented Sep 21, 2012

I'm busy these days, and don't have much time and we need some more contributors. Apply within!

@jlongster

This comment has been minimized.

Show comment
Hide comment
@jlongster

jlongster Oct 24, 2012

I've used swank-js off and on, and I really appreciate that it exists. The code seems pretty straight-forward and I've hacked on it a little bit to get it to work with projects that have a different structure. I might try to fix some bugs at some point but I can't promise much right now. I'm definitely interested in it sticking around though.

I've used swank-js off and on, and I really appreciate that it exists. The code seems pretty straight-forward and I've hacked on it a little bit to get it to work with projects that have a different structure. I might try to fix some bugs at some point but I can't promise much right now. I'm definitely interested in it sticking around though.

@jonnay

This comment has been minimized.

Show comment
Hide comment
@jonnay

jonnay Oct 30, 2012

Member

@ivan4th How do you feel about either adding jlongster or giving me admin access to the project? Thanks!

Member

jonnay commented Oct 30, 2012

@ivan4th How do you feel about either adding jlongster or giving me admin access to the project? Thanks!

@ivan4th

This comment has been minimized.

Show comment
Hide comment
@ivan4th

ivan4th Oct 30, 2012

Member

@jonnay Added you to 'Owners' team.

Member

ivan4th commented Oct 30, 2012

@jonnay Added you to 'Owners' team.

@ivan4th

This comment has been minimized.

Show comment
Hide comment
@ivan4th

ivan4th Oct 30, 2012

Member

Added jlongster to developers.

Member

ivan4th commented Oct 30, 2012

Added jlongster to developers.

@jonnay

This comment has been minimized.

Show comment
Hide comment
@jonnay

jonnay Oct 30, 2012

Member

Sweet! Thank you!

Member

jonnay commented Oct 30, 2012

Sweet! Thank you!

@jonnay jonnay closed this Oct 30, 2012

@jlongster

This comment has been minimized.

Show comment
Hide comment
@jlongster

jlongster Nov 23, 2012

Hey guys -- to be honest, I've got a ton on my plate and I'm getting by with swank.js right now, not sure I'll have time to dig in and fix stuff. Unfortunately I really only use it to refresh CSS on the fly. A lot of the javascript I work with is wrapped up in a require.js module, so it's completely inaccessible to the REPL, which makes me really sad. Until javascript gets proper modules, I don't think there's anything we can do about that.

Just letting you guys know that I won't be able to contribute much in the near future.

Hey guys -- to be honest, I've got a ton on my plate and I'm getting by with swank.js right now, not sure I'll have time to dig in and fix stuff. Unfortunately I really only use it to refresh CSS on the fly. A lot of the javascript I work with is wrapped up in a require.js module, so it's completely inaccessible to the REPL, which makes me really sad. Until javascript gets proper modules, I don't think there's anything we can do about that.

Just letting you guys know that I won't be able to contribute much in the near future.

@jonnay

This comment has been minimized.

Show comment
Hide comment
@jonnay

jonnay Nov 28, 2012

Member

I think everyone is in that boat. C'est la vie!

Member

jonnay commented Nov 28, 2012

I think everyone is in that boat. C'est la vie!

@jonnay jonnay reopened this Nov 28, 2012

@lazywithclass

This comment has been minimized.

Show comment
Hide comment
@lazywithclass

lazywithclass Aug 28, 2013

Hi, I'm trying to fix what I think could be a bug, is there a way to run all the tests?
I'm working in completion.js, I thought about writing a test first but running node completion-tests.js gave me

'completion eval error: TypeError' is expected: completion eval error: TypeError: Cannot read property 'bar' of undefined

is there something I'm missing? Sorry if this sounds obvious, but I would like to contribute.

EDIT:

I just saw this commit: 390f0e1 and realized this is not a failing test.

Hi, I'm trying to fix what I think could be a bug, is there a way to run all the tests?
I'm working in completion.js, I thought about writing a test first but running node completion-tests.js gave me

'completion eval error: TypeError' is expected: completion eval error: TypeError: Cannot read property 'bar' of undefined

is there something I'm missing? Sorry if this sounds obvious, but I would like to contribute.

EDIT:

I just saw this commit: 390f0e1 and realized this is not a failing test.

@erjoalgo

This comment has been minimized.

Show comment
Hide comment
@erjoalgo

erjoalgo Aug 1, 2015

Contributor

I just made a pull request mainly to fix some deprecated functions. Please take a look at it. Thanks

Contributor

erjoalgo commented Aug 1, 2015

I just made a pull request mainly to fix some deprecated functions. Please take a look at it. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment