Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding ordering and other help to the english readme. #17

Merged
merged 1 commit into from
Feb 28, 2022
Merged

Adding ordering and other help to the english readme. #17

merged 1 commit into from
Feb 28, 2022

Conversation

christrotter
Copy link
Contributor

Added a few items that I found helpful to know when ordering...

  • A note about mini LED naming differences
  • A new section outlining ordering with both Elecrow and JLCPCB

@christrotter christrotter mentioned this pull request Feb 28, 2022
Closed
@swanmatch swanmatch merged commit f193145 into swanmatch:master Feb 28, 2022
@swanmatch
Copy link
Owner

Thanks @christrotter

@swanmatch
Copy link
Owner

@christrotter
I merged them for now, but some of the tables in Ordering PCBs seem to be broken.
Please fix it if you can.
https://swanmatch.github.io/MxLEDBitPCB/readme_en.html

@christrotter
Copy link
Contributor Author

@swanmatch The tables work in straight github. I'll take a look at why github.io is not formatting properly...

@swanmatch swanmatch mentioned this pull request Feb 28, 2022
Merged
@christrotter
Copy link
Contributor Author

christrotter commented Mar 1, 2022 •
edited
Loading

I think this... pages-themes/cayman#82 (edit: did not actually end up using this)
Sending another PR.

@christrotter
Copy link
Contributor Author

#19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@christrotter @swanmatch