Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error handling #51

Closed
8 tasks done
swapagarwal opened this issue May 26, 2016 · 8 comments
Closed
8 tasks done

Add error handling #51

swapagarwal opened this issue May 26, 2016 · 8 comments
Labels
Improvement Low-Hanging Fruit

Comments

@swapagarwal
Copy link
Owner

swapagarwal commented May 26, 2016 •
edited

Below is the list of modules that need a output['error_msg'] in case of an exception:

  • anime
  • book
  • currency
  • dictionary Line#20
  • movie
  • music
  • time
  • wiki
@jorgeavaldez
Copy link

I can take this

@swapagarwal
Copy link
Owner Author

sure @jorgeavaldez, let me know if you need any help! 😄

@camdroid
Copy link
Contributor

camdroid commented Jun 3, 2016

@jorgeavaldez Are you still working on this, or would it be okay if I worked on a couple modules?

@swapagarwal
Copy link
Owner Author

@camdroid There are many modules so feel free to take up any of them! 😉

@camdroid
Copy link
Contributor

camdroid commented Jun 6, 2016

Added pull request for currency (#65) and anime (#66).

@shnupta shnupta mentioned this issue Jun 7, 2016
Closed
swapagarwal pushed a commit that referenced this issue Jun 8, 2016
@camdroid @swapagarwal
Currency: Add error message (#65)
6d08eab 
See #51 

* Added error message for currency conversions

* Reordered output assignment
swapagarwal pushed a commit that referenced this issue Jun 8, 2016
@camdroid @swapagarwal
Anime: Add error message (#66)
229a444 
See #51 

* Added error message for finding anime.

* Reordered output assignment
@nikhilgeo
Copy link
Contributor

@swapagarwal ...I like to work on this..!!

@swapagarwal
Copy link
Owner Author

@nikhilgeo This is being done in #74
Feel free to take up any of the other issues. 😄

@nikhilgeo
Copy link
Contributor

ok...Cool..!!

@shnupta shnupta mentioned this issue Jun 8, 2016
Merged
swapagarwal pushed a commit that referenced this issue Jun 9, 2016
@shnupta @swapagarwal
Add remaining error messages (#78)
5e02b5b 
See #51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement Low-Hanging Fruit
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@camdroid @swapagarwal @nikhilgeo @jorgeavaldez